Skip to content

Pipe: Enabled config audit logger & Fixed some checks of config privilege & keep the tree model show pipes aligned with table model's & Fixed the bug that password with "-" prefix cannot be directly entered in Cli & Fixed some pipe ITs & Added the missing source privilege check for PipeAlterEncodingCompressorPlan #16957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jt2594838 merged 29 commits into from
Jan 5, 2026
Merged

Pipe: Enabled config audit logger & Fixed some checks of config privilege & keep the tree model show pipes aligned with table model's & Fixed the bug that password with "-" prefix cannot be directly entered in Cli & Fixed some pipe ITs & Added the missing source privilege check for PipeAlterEncodingCompressorPlan #16957

jt2594838 merged 29 commits into from
Jan 5, 2026

Conversation

@Caideyipi
Copy link
Collaborator

@Caideyipi Caideyipi commented Dec 26, 2025

Description

As the title said.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi changed the title Pipe: Enabled config audit logger & Fixed some checks of config privilege & keep the tree model show pipes aligned with table model's Pipe: Enabled config audit logger & Fixed some checks of config privilege & keep the tree model show pipes aligned with table model's & Fixed the bug that password with "-" prefix cannot be directly entered in Cli Dec 26, 2025
@codecov
Copy link

codecov bot commented Dec 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 21.31661% with 502 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.30%. Comparing base (c531044) to head (13f0c4d).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ipe/receiver/protocol/IoTDBConfigNodeReceiver.java 0.00% 196 Missing ⚠️
...an/relational/security/TreeAccessCheckVisitor.java 2.38% 82 Missing ⚠️
...ne/plan/relational/security/AccessControlImpl.java 0.00% 81 Missing ⚠️
...e/source/PipeConfigTablePrivilegeParseVisitor.java 0.00% 69 Missing ⚠️
...pe/source/PipeConfigTreePrivilegeParseVisitor.java 79.50% 33 Missing ⚠️
...lan/relational/security/ITableAuthCheckerImpl.java 0.00% 26 Missing ⚠️
...pache/iotdb/commons/audit/AbstractAuditLogger.java 37.50% 5 Missing ⚠️
...e/manager/pipe/source/IoTDBConfigRegionSource.java 0.00% 3 Missing ⚠️
.../plan/execution/config/TableConfigTaskVisitor.java 0.00% 3 Missing ⚠️
...iotdb/commons/pipe/receiver/IoTDBFileReceiver.java 0.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #16957      +/-   ##
============================================
+ Coverage     39.29%   39.30%   +0.01%     
  Complexity      212      212              
============================================
  Files          5058     5058              
  Lines        337842   337977     +135     
  Branches      43026    43054      +28     
============================================
+ Hits         132763   132855      +92     
- Misses       205079   205122      +43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CRZbulabula
CRZbulabula requested changes Dec 28, 2025
View reviewed changes
Copy link
Contributor

@CRZbulabula CRZbulabula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL.

CRZbulabula
CRZbulabula approved these changes Dec 29, 2025
View reviewed changes
Copy link
Contributor

@CRZbulabula CRZbulabula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Caideyipi Caideyipi changed the title Pipe: Enabled config audit logger & Fixed some checks of config privilege & keep the tree model show pipes aligned with table model's & Fixed the bug that password with "-" prefix cannot be directly entered in Cli Pipe: Enabled config audit logger & Fixed some checks of config privilege & keep the tree model show pipes aligned with table model's & Fixed the bug that password with "-" prefix cannot be directly entered in Cli & Fixed some pipe ITs Dec 29, 2025
@Caideyipi Caideyipi changed the title Pipe: Enabled config audit logger & Fixed some checks of config privilege & keep the tree model show pipes aligned with table model's & Fixed the bug that password with "-" prefix cannot be directly entered in Cli & Fixed some pipe ITs Pipe: Enabled config audit logger & Fixed some checks of config privilege & keep the tree model show pipes aligned with table model's & Fixed the bug that password with "-" prefix cannot be directly entered in Cli & Fixed some pipe ITs & Added the missing source privilege check for PipeAlterEncodingCompressorPlan Jan 4, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2026

Quality Gate Passed Quality Gate passed

Issues
40 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarQube Cloud

@jt2594838 jt2594838 merged commit ecd7d92 into master Jan 5, 2026
31 checks passed
@jt2594838 jt2594838 deleted the enable-time-other-name branch January 5, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jt2594838 jt2594838 jt2594838 approved these changes

@CRZbulabula CRZbulabula CRZbulabula approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Caideyipi @jt2594838 @CRZbulabula